Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable naming issues #145

Open
akshaylive opened this issue Dec 8, 2023 · 3 comments · May be fixed by #146
Open

Variable naming issues #145

akshaylive opened this issue Dec 8, 2023 · 3 comments · May be fixed by #146

Comments

@akshaylive
Copy link

I was following the reparameterization code.

During invocation, the variable posterior_log_sigma is incorrectly named. It's supposed to be posterior_log_variance. Similarly, the inf net needs to be renamed to variance instead of sigma.

However, the naming here is accurate.

@vinid
Copy link
Contributor

vinid commented Dec 8, 2023

Thanks, that make sense! Do you want to open a PR for that?

@akshaylive akshaylive linked a pull request Dec 8, 2023 that will close this issue
@akshaylive
Copy link
Author

I've opened the PR. I haven't actually executed it though. Please review/merge with caution. :)

@akshaylive
Copy link
Author

Please ignore the previous comment - the tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants