Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw on NaN without throwing on more than 15 significant digits #324

Open
subos2008 opened this issue Mar 24, 2022 · 1 comment
Open

Throw on NaN without throwing on more than 15 significant digits #324

subos2008 opened this issue Mar 24, 2022 · 1 comment

Comments

@subos2008
Copy link

I'm using DEBUG=true to convert NaN values into exceptions. However, there are other side effects of DEBUG=true that I pick up from using that.

Is it possible to convert NaN's to exceptions without other side effects?

@MikeMcl
Copy link
Owner

MikeMcl commented Mar 24, 2022

Well, you could just use, for example:

x = new BigNumber(val);
if (x.isNaN()) {
  throw Error(`${val} is not a valid BigNumber value`);
}

Related to #246.

I'm considering removing the 15 significant digit limit and throwing on NaN in DEBUG mode in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants