Skip to content
This repository has been archived by the owner on Jan 21, 2023. It is now read-only.

Constrain elements that can be added to each view type #79

Open
1 task done
yt-ms opened this issue May 11, 2021 · 1 comment
Open
1 task done

Constrain elements that can be added to each view type #79

yt-ms opened this issue May 11, 2021 · 1 comment

Comments

@yt-ms
Copy link
Collaborator

yt-ms commented May 11, 2021

Checklist

Is your feature related to a problem? Please describe it.

In the Java implementation, each view class overrides checkElementCanBeAdded which is defined abstractly in View. Without having this, it is possible to add elements to a view that then would not be supported in Structurizr itself.

Describe the solution you would like.

Mirror the Java implementation with an abstract check_element_can_be_added method in View which each subtype overrides.

Additional context

from structurizr import Workspace
workspace = Workspace(name="Test", description="Test")
system = workspace.model.add_software_system(name="System 1")
container = system.add_container(name="Container 1")
view = workspace.views.create_container_view(key="con1", description="test", software_system=system)

# This should fail but doesn't
view.add(system)
yt-ms added a commit to yt-ms/structurizr-python that referenced this issue May 11, 2021
@yt-ms
Copy link
Collaborator Author

yt-ms commented May 11, 2021

I've added an xfail test in test_container_view to demonstrate this issue in PR #78.

Midnighter pushed a commit that referenced this issue Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant