Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I found a mistake in dsmcCLLWallPatch #11

Open
hpleskun opened this issue Oct 15, 2021 · 0 comments
Open

I found a mistake in dsmcCLLWallPatch #11

hpleskun opened this issue Oct 15, 2021 · 0 comments

Comments

@hpleskun
Copy link

Hello,

I made some simulations on the Couette flow using the dsmcCLLWallPatch and was wondering about unphysical results.
After regarding the input files several times I looked into the code dsmcCLLWallPatch.C and there is a mistake regarding the TMAC for the tangential wall velocity in lines 249 and 250 concerning the alphaT with the definition in line 152:
const scalar& alphaT = tangentialAccommodationCoefficient_*(2.0 - tangentialAccommodationCoefficient_);

The tangential wall velocity must be multiplied by tangentialAccommodationCoefficient_ not by alphaT. Otherwise the simulated wall velocity is unphysically increased. I did simulations with both the dsmcMixedDiffuseSpecularWallPatch and the CLL model. After the correction I got similar results with both models on the trivial case of an isothermal Couette flow. Before this correction the results of the CLL model could generate a higher mass flow rate than can be indicated by the wall speed. I give a snipped of the current code and my proposal of the correction below from lines 245 to 252:

Current code:

vector uWallNormal = (velocity_ & nw) * nw;
vector uWallTangential1 = (velocity_ & tw1) * tw1; 
vector uWallTangential2 = (velocity_ & tw2) * tw2;
vector UNormal = ((U & nw) * nw) + uWallNormal*alphaN;  
vector UTangential1 = (U & tw1) * tw1 + uWallTangential1*alphaT;
vector UTangential2 = (U & tw2) * tw2 + uWallTangential2*alphaT;

U = UNormal + UTangential1 + UTangential2;

Corrected Code:

vector uWallNormal = (velocity_ & nw) * nw;
vector uWallTangential1 = (velocity_ & tw1) * tw1; 
vector uWallTangential2 = (velocity_ & tw2) * tw2;
vector UNormal = ((U & nw) * nw) + uWallNormal*alphaN;  
vector UTangential1 = (U & tw1) * tw1 + uWallTangential1*tangentialAccommodationCoefficient_;
vector UTangential2 = (U & tw2) * tw2 + uWallTangential2*tangentialAccommodationCoefficient_;

U = UNormal + UTangential1 + UTangential2;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant