New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doubts on computing keypoints #33
Comments
Hi, Arthur, the differences however are mainly of that current implementation is also checking circle pattern corners - so if you will run the detector in full image pyramid, you will get on these provided examples much less keypoints (so generally better working point on ROC curve). note that your imp. is firing a lot on strait lines. but anyway - I can not claim that it is better :) - just depend on data and your requirements |
Hi Michal,
Best regards |
Hi Artur, The rule for output bends (line 245): so for the provided example (countR + countAll) < 10 does not hold for corners. If desired (countR + countAll) <= 10 will do. about the corner - sorry, i was wrong - the corner crossing is commented out ( //int x = getValueCorner12(ptr, pixel, corners, pixelIndex[l], k, maxdist ); All the best, Michal |
Hi Michal,
I have an input image:
When I compute keypoints according to article (own implementation) I receive:
Buy after computing keypoints according to your original version from GitHub I receive:
Could you please tell why these versions differ and which is better?
The text was updated successfully, but these errors were encountered: