Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseCacheManager 'rethrows' exceptions losing stack trace #303

Open
ndrwrbgs opened this issue Feb 27, 2020 · 1 comment · May be fixed by #306 or #307
Open

BaseCacheManager 'rethrows' exceptions losing stack trace #303

ndrwrbgs opened this issue Feb 27, 2020 · 1 comment · May be fixed by #306 or #307

Comments

@ndrwrbgs
Copy link

There are ways to 'rethrow' the exception directly rather than throw ex again (which will overwrite the StackTrace and says that the exception came from BaseCacheManager rather than the underlying cache handle.
@ndrwrbgs
Copy link
Author

[I plan to submit a PR for this]

ndrwrbgs added a commit to ndrwrbgs/CacheManager that referenced this issue Feb 28, 2020
@ndrwrbgs
Fixes MichaCo#303, but is a breaking change in that the exception typ…
f12fd15 
…e thrown would change.
ndrwrbgs added a commit to ndrwrbgs/CacheManager that referenced this issue Feb 28, 2020
@ndrwrbgs
Fixes MichaCo#303, add Rethrow() method
cdf7d2a
This was referenced Feb 28, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ndrwrbgs