Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for maintainers - please reach out! #356

Open
raix opened this issue Dec 13, 2018 · 29 comments
Open

Looking for maintainers - please reach out! #356

raix opened this issue Dec 13, 2018 · 29 comments

Comments

@raix
Copy link
Collaborator

raix commented Dec 13, 2018

No description provided.

@raix raix pinned this issue Dec 13, 2018
@da314pc
Copy link
Collaborator

da314pc commented Dec 21, 2018

@raix I am interested. I use this package heavily.

@shivang007
Copy link
Collaborator

Sounds interesting and a good idea, as raix/push is highly used in meteor community it needs maintenance.

@raix
Copy link
Collaborator Author

raix commented Jan 2, 2019

@da314pc and @shivang007 do both of you want to be added as maintainers? (I'll need your Meteor developer login name for allowing you to publish)

@shivang007
Copy link
Collaborator

That will be awesome @raix
My Meteor dev username: shivangkar7

@da314pc
Copy link
Collaborator

da314pc commented Jan 3, 2019

@raix My meteor dev username: da314pc

@raix
Copy link
Collaborator Author

raix commented Jan 6, 2019

@shivang007 and @da314pc I have added you to the repository and meteor group - so you should be able to release new versions etc. let me know if it doesn't work or if you need more information on the package. Thanks guys

@aboire
Copy link
Collaborator

aboire commented Jan 8, 2019

@da314pc @shivang007 do you have to watch this pull request #354 which allows to use fcm for android and ios

@da314pc
Copy link
Collaborator

da314pc commented Jan 8, 2019

@aboire that has definitely been something I wanted to add to this library.

As far as the next release there a couple things I think we have to tackle.

  1. Better integration for android 8.0 oreo
  2. take a look at the APN library, there has been so many changes and reported issues we need to upgrade to a stable version
    Thousands tokens node-apn/node-apn#557 (comment)
  3. FCM for ios could be more reliable on ios, but we should still keep APN support.

@aboire
Copy link
Collaborator

aboire commented Jan 8, 2019

@da314pc for the 2: apn it might be necessary to add this pull request #327

@da314pc
Copy link
Collaborator

da314pc commented Jan 8, 2019

@aboire yes we have that open.
I just want to make sure that issues like: node-apn/node-apn#583
are not being introduced once we upgrade.

@shivang007
Copy link
Collaborator

@da314pc @shivang007 do you have to watch this pull request #354 which allows to use fcm for android and ios

@aboire Yes that is definitely on the to-do list

@raix
Copy link
Collaborator Author

raix commented Jan 9, 2019

@aboire do you want to be part of the maintainer group?

@aboire
Copy link
Collaborator

aboire commented Jan 11, 2019

@raix if i can help yes

@raix
Copy link
Collaborator Author

raix commented Jan 14, 2019

@aboire I've added you to the repo - lmk if you need publish access

@shivang007
Copy link
Collaborator

@raix Can we please have a slack/spectrum/any group to improve our communication gap?

@raix
Copy link
Collaborator Author

raix commented Feb 18, 2019

@shivang007 It makes sense - are you guys setting it up or should I?

@shivang007
Copy link
Collaborator

@raix You set it up, we will join.

@raix
Copy link
Collaborator Author

raix commented Feb 19, 2019

I've created https://meteoropensourcecomm.slack.com - and added a channel for "meteor-push" @da314pc I don't have your email to send an invite - @shivang007 @aboire Please help invite

@da314pc
Copy link
Collaborator

da314pc commented Feb 25, 2019

@raix I have sent you an email.

@BrianMulhall
Copy link

is there still a need for help? i would like to contribute if possible

@da314pc
Copy link
Collaborator

da314pc commented Sep 7, 2019

@BrianMulhall yea, more people are always better. We need better docs for the new apn tokens, and also alot fo people have migrated to react natvie, but this project is still great for a back-end service. So i wanted to have a more update to guide for them,

@BrianMulhall
Copy link

if i were to fork this repo and then familiarize myself with it would that include all the code/doc/tests/examples/etc that support the project? or are there other areas that contain relevant information?

@BrianMulhall
Copy link

and the react-native users no longer use meteor for their applications but could still make use of this code running (server side) on node for their new projects? I'm not sure I am following that comment 100 percent

@da314pc
Copy link
Collaborator

da314pc commented Sep 7, 2019

Yes you would be familiar with this project. As far as react native, This project has 2 parts,
the client - which manages all of the token registration, token removal,
the server- which integrates node fcm, & apple apn services into a nice clean api for meteorjs

we can still use the server, but i think there has been some confusion on how to integrate it.

@BrianMulhall
Copy link

ok cool, let me get up to speed with the repo and take a look around and I am going to try and get it working with a meteor project i have set up just to see it action. then ill reach out and see how i can be of any help.

@da314pc
Copy link
Collaborator

da314pc commented Sep 7, 2019

Awesome, the hardest part is the setup. Apple's push service wont really work until you have a beta app out, through the app store, but google's fcm service will work just running the app on an android phone. Just remember to have the Server settings set to dev.

@BrianMulhall
Copy link

i am able to get it working through firebase cloud messaging on an android device running 8.1 with phonegap-plugin-push version 2.2.3 as my cordova plugin. Worked liked a charm. so next step for me is to take a look around the code and then do a bit of a ramp up on how push actually works (like the internals of it all). just so i know whats what

@BrianMulhall
Copy link

i think if i could help out with documentation and maybe testing until i am familiar with things that would be a good place to start. I cant do much damage haha and ill learn the project

@raix raix unpinned this issue Aug 8, 2020
@StorytellerCZ
Copy link
Member

If anyone is willing to take on maintaining this project please ping me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants