Use collection extensions #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you have any questions or if there's something I can do to help. Would it help if I tested it out the dependant packages using this? |
|
Looks really good, nice work. If you're happy for me to merge and release I'll do so. |
|
Thanks. Go for it. |
|
Merged & released. Thanks @rclai ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, so I did it!
In addition, I refactored my fork of collection hooks to use my package and all tests passed! I'll probably pull request them too. If they don't accept that's okay because the package will still work even if collection-hooks doesn't depend on my package.
This should fix #13.
If you'd like, you can clone it into a local packages folder to test it and see if it works.
Let me know.