Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

before hooks and async callbacks are not compliant with Meteor 3 promises #308

Open
vincentcarpentier opened this issue Feb 7, 2024 · 4 comments

Comments

@vincentcarpentier
Copy link

vincentcarpentier commented Feb 7, 2024

For example this code cannot works with an async callback without any "await" keyword.
We are not able to cancel updates (nor inserts or deletes) by returning false.

Can you prioritize this feature to allow us complete our refactoring of our code base to Meteor 3 please ? 🙏
image

Copy link

github-actions bot commented Feb 7, 2024

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously.
Our goal is to provide long-term lifecycles for packages and keep up
with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time.
Therefore, we can't guarantee you issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit
a pull request, too! We will accompany you in the process with reviews and hints
on how to get development set up.

Please also consider sponsoring the maintainers of the package.
If you don't know who is currently maintaining this package, just leave a comment
and we'll let you know.

@filipenevola
Copy link

Hey, @StorytellerCZ, how is the MCP work handled? Are you guys assigning issues to people, or is it just going on "free will" of all collaborators?

@StorytellerCZ
Copy link
Member

free will

@bhunjadi
Copy link

I was planning to solve this under #309 .
Basically everything in Meteor v3 should be able to be async and hooks would await if necessary.

I just have to figure out if there's an easy way to be both Meteor 2.0 and 3.0 compatible with a lot of c/p code that would be potentially required for sync and async versions of hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants