Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix execute async API #168

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix execute async API #168

wants to merge 2 commits into from

Conversation

rukai
Copy link
Contributor

@rukai rukai commented Apr 17, 2023

closes #163

rukai and others added 2 commits April 18, 2023 08:37
Signed-off-by: Lucas Kent <rubickent@gmail.com>
@kw217
Copy link
Collaborator

kw217 commented Apr 18, 2023

Thanks, this looks great! Unfortunately for my application it's exposed the lack of #164 . We were inadvertently still using the old API, and hadn't noticed that we do execute the same statement multiple times and it's impractical to recreate the statement (in some circumstances we have our own retry logic).

I'm going to hold off merging until #164 is fixed. I have a proposal there for how we might fix that - comments welcome.

@kw217 kw217 added the blocked label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch::execute consumes the batch while Connection::execute_batch while does not
2 participants