Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metacello reloads all packages that are specified in the baseline and are present in the image even if I try to load only the group that does not contain them. #483

Open
dalehenrich opened this issue Mar 2, 2018 · 1 comment

Comments

@dalehenrich
Copy link
Member

@pavel-krivanek reported the following in another presumably partially related issue:

I have the same problem and it does not seem to be related to the naming convention. In the baseline (of Moose) I have some packages like 'WebBrowser-Core' or GT that are by default loaded in the image. The baseline then specifies a group that contains only one different package that has no dependency on other packages. But anyway, Metacello reloads all packages that are specified in the baseline and are present in the image even if I try to load only the group that does not contain them.

Followed by the this comment.

For this baseline:

	spec for: #'common' do: [
		spec 

			package: #'WebBrowser-Core';
			package: #'CustomPackage'.
		spec 
			group: 'Core' with: #(#'CustomPackage').]

and this loading command:

Metacello new
  baseline: 'MetacelloIssue472';
  repository: 'github://pavel-krivanek/playground';
  load: 'Core'

it loads:

linear load : 
	linear load : baseline [BaselineOfMetacelloIssue472]
		load : WebBrowser-Core-PavelKrivanek.1519989037
		load : CustomPackage-PavelKrivanek.1519989037

The package WebBrowser-Core is some package that is present by default in the image in time of loading of the baseline.

@dalehenrich
Copy link
Member Author

@pavel-krivanek, there are a couple of things that I need to know.

First, does the baseline use Cypress, i.e., the method MetacelloIssue472>>packageSpecClass returns MetacelloCypressPackageSpec ... if so, then it is expected that all loaded packages in the project will be fetched and loaded ... although given the way that Monticello works, if there are not actual changes in the package, then the package load is a noop.

Secondly, how does the package WebBrowser-Core get loaded into the image? If it was loaded by Metacello in an earlier load expression, then the package is counted as a loaded package and the above comment applies.

If neither of these conditions apply, then I guess we'll need to do a little more work to characterize things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant