-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
credentials.conf handling of certain characters in usernames and passwords #989
Comments
perhaps we could have an alternative syntax with a separate keyword... aka: amqp://user@hoho password=lovel/ so use something completely different than urlparse. There is already syntax for other keywords later in the line... |
look at sarracenia/credentials.py syntax examples given with passive= and binary keywords. |
Yes, I like that idea! Another option would be using a keyword to tell sr3 whether the username and password is url encoded or not.
username = |
I like the urlencode keyword idea also... probably that is a better approach |
I vaguely recalle we tried always url encoding in the past, and something bad happenned, so we had to roll back... so use of the keyword does seem necessary. #884 is the thing I remember... |
The documentation does say that credentials are URL encoded: https://metpx.github.io/sarracenia/Reference/sr3_credentials.7.html#credential-details
|
I was not able to use a password that had
/
in it in sr3.I was using a plugin, so I was able to workaround it by using
%2F
in credentials.conf andurllib.parse.unquote
in the plugin.The problem seems to come from urllib.parse.urlparse:
The text was updated successfully, but these errors were encountered: