Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollToLastItem(at:animated:) is not scrolling to bottom properly. #1830

Open
hidayetozsoy opened this issue Feb 14, 2024 · 2 comments
Open
Labels

Comments

@hidayetozsoy
Copy link

The Bug
The scrollToLastItem(at:animated:) method is not scrolling to the bottom properly. It eliminates the gap between last cell and inputBarAccessoryView. This issue is visible in the video I recorded from the Example app of MessageKit. It seems the method only makes the last item completely visible without considering the bottom inset and eliminates the space between the inputBarAccessoryView and the message cell.

To Reproduce
Open Example MessageKit app, open Basic Example screen, wait for bots to send message, or you can send yourself, messagesCollectionView will scroll to bottom automatically. Then try to scroll manually, it will scroll a little bit more, which is expected when programatically scrolled.

Expected behavior
The gap between inputBarAccessoryView messagesCollectionView should be kept when programatically scrolled.

Screenshots
Simulator Screen Recording - iPhone 15 Pro Max - 2024-02-14 at 04 16 50

Environment

  • What version of MessageKit are you using?
    4.2.0 (commit c7f278c)

  • What version of iOS are you running on?
    IOS 17.0.1 on Simulator iPhone 15 Pro Max
    IOS 17.2.1 on Physical Device iPhone 13

  • What version of Swift are you running on?
    Swift 5.9

  • What device(s) are you testing on? Are these simulators?
    IOS 17.0.1 on Simulator iPhone 15 Pro Max
    IOS 17.2.1 on Physical Device iPhone 13

  • Is the issue you're experiencing reproducible in the example app?
    Yes.

(I don't know why but GIF is not repeating, you can see it after refresh)

@hidoon
Copy link

hidoon commented Feb 20, 2024

I created a PR for this issue.
#1832

@luoshuaiqing
Copy link

Hi, I encountered a similar though different issue, as mentioned in the fix PR. Would really appreciate your help, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants