Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swa_get_peaks fails to handle a special case #36

Open
grahamfindlay opened this issue Feb 4, 2016 · 0 comments
Open

swa_get_peaks fails to handle a special case #36

grahamfindlay opened this issue Feb 4, 2016 · 0 comments

Comments

@grahamfindlay
Copy link
Contributor

Checking for negative and positive peaks this way...

MNP  = find(diff(sign(slope_data)) == 2);
MPP  = find(diff(sign(slope_data)) == -2);

...fails to properly handle the case where the slope at the peak is exactly zero.

E.g. it catches peaks like / but misses peaks like _/.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grahamfindlay