Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove critical error for vinyl tracknumber tags #40

Open
MacroPower opened this issue Jan 3, 2019 · 0 comments
Open

Remove critical error for vinyl tracknumber tags #40

MacroPower opened this issue Jan 3, 2019 · 0 comments

Comments

@MacroPower
Copy link

        tracknumber = info['tracknumber'][0]
        if not valid_fractional_tag(tracknumber):
            return (False, '"%s" has a malformed tracknumber tag ("%s")' % (filename, tracknumber))

We currently have this block dictating what is "acceptable" for tracknumber tags.

However, it does not account for vinyl releases. It has been long upheld that A1, B7, etc are acceptable tracknumber tags.

Perhaps this could be changed to simply be an info message, or be refined to allow tags such as "A1" or "C6/20".

In the very least we could have an option to ignore the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant