stateful_browser.py: add a response property #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever we set the browser state, include the request response. The `response` property will raise an `AttributeError` if the state has not yet been set. This is not strictly necessary, since we return the request response in most functions that have one, but it is perhaps a convenience in some scenarios. Closes MechanicalSoup#358.
|
One thing that makes me vaguely hesitant about this change is users getting confused about when the response is updated. For example, response = browser.download_link(...)will not be the same browser.download_link(...)
response = browser.responseThe same is already true for the current components of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we set the browser state, include the request response.
The
responseproperty will raise anAttributeErrorif the statehas not yet been set.
This is not strictly necessary, since we return the request response
in most functions that have one, but it is perhaps a convenience in
some scenarios.
Closes #358.