Store latest response in the browser state

[LVerneyPEReN]

Hi,

It seems the latest request and soup is stored in the browser state but not the latest response object. I have a use case where this would be useful, typically for getting access to headers defined in the last response (content-type for non HTML content for example).

Would it make sense to write something to store the last response in the browser state?

Best,

[hemberger]

Thanks for your question, and sorry for the delayed response!

While the response is not stored in the browser state, it is returned by all methods that produce one. Is that sufficient, or do you really need it to be carried along with the StatefulBrowser instance?

That said, I can't think of any compelling reason to not store the response in the browser state. Does anyone else have any thoughts about this?

[LVerneyPEReN]

Hi @hemberger,

Thanks for the feedback on this one! My use case is typically to consume the StatefulBrowser.response differently depending on the Content-Type of the response. I browse either HTML pages or JSON results and in the first case, the StatefulBrowser.page gets populated, but in the later case, the response is discarded from the browser state. Then, I have to deal manually with the response as returned by the calls to StatefulBrowser.open and I lose the main interest of the StatefulBrowser by reproducing part of its logic in my own app.

Storing the last response object in _BrowserState alongside the request object would let me check for the latest response content type and either consume StatefulBrowser.soup or StatefulBrowser.__state.response.json() (or even StatefulBrowser.__state.response.text to get the raw HTML/JSON text).