Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI Submission and other improvements #68

Open
adithyabsk opened this issue Nov 8, 2020 · 3 comments
Open

PyPI Submission and other improvements #68

adithyabsk opened this issue Nov 8, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@adithyabsk
Copy link
Contributor

I have some experience with python packaging and would love to help out here. Thought I would create an issue first before spending some time on a pull request.

Other general clean up suggestions I have:

Please see this repo for a rough idea for what I have in mind: https://github.com/adithyabsk/keep2roam

@adithyabsk adithyabsk added the enhancement New feature or request label Nov 8, 2020
@MatthieuBizien
Copy link
Owner

Hi @adithyabsk, your proposal seems interesting.

  • Roam-to-git-demo lives in a separate git repository, because it generate a lot of commits. We can disable the cron to run it on the main repository, but I'm not sure how to integrate it. Any idea?
  • What linting checks do you have in mind?
  • Automatic Pypi submission would be nice, PR welcome 👍

BTW keep2roam is a good idea, it would have helped me when I started using Roam. Do you plan to automatize the process?

@MatthieuBizien
Copy link
Owner

Regarding CI, I added a flake8 lint in #69, and build matrix in #70, but I'm not sure I will catch anything with the last one, as the tested functions don't depends on the os.

@adithyabsk
Copy link
Contributor Author

Glad you like keep2roam, I don't think I can automatize the process since it requires Google Takeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants