Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git process is terminated before it finishes pushing the repository #117

Open
Stvad opened this issue Mar 10, 2024 · 5 comments
Open

Git process is terminated before it finishes pushing the repository #117

Stvad opened this issue Mar 10, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Stvad
Copy link

Stvad commented Mar 10, 2024

Describe the bug
The backup seems to complete successfully, but workflow terminates before git can push changes to the repository.

To Reproduce
Use the workflow with large-enough Road database?

Expected behavior
Git process is allowed to complete, instead it's terminated by

def _kill_child_process(timeout=50):

Traceback
See log in https://github.com/Stvad/roam-notes-workflow/actions/runs/8224616595/job/22488653469

Please complete the following information:

  • OS: Ubuntu-latest
  • Do you use Github Action?: Yes
  • Do you use multiple Roam databases?: No
  • Does roam-to-git use to work for you? When precisely did it stopped to work?: Restarting using it after long period of inactivity
  • Does some backup runs are still working? No
@Stvad Stvad added the bug Something isn't working label Mar 10, 2024
@Stvad
Copy link
Author

Stvad commented Mar 10, 2024

I've tried disabling that cleanup with 558917b but it seems the issue is that for some reason parent process is terminated, so just disabling cleanup is not sufficient 🤔

@Stvad
Copy link
Author

Stvad commented Mar 11, 2024

Ok, can repro locally on macos as-well

@Stvad
Copy link
Author

Stvad commented Mar 11, 2024

ah, got to the root of it =\

remote: error: See https://gh.io/lfs for more information.
remote: error: File json/dbname.json is 126.14 MB; this exceeds GitHub's file size limit of 100.00 MB
remote: error: GH001: Large files detected. You may want to try Git Large File Storage - https://git-lfs.github.com.

@Stvad
Copy link
Author

Stvad commented Mar 11, 2024

Ok, after configuring LFS manually and commiting the .gitattributes file - things work now https://docs.github.com/en/repositories/working-with-files/managing-large-files/configuring-git-large-file-storage

@Stvad
Copy link
Author

Stvad commented Mar 11, 2024

ah, but github LFS has 1gb limit and it seems it uploads a new file each time instead of diffing, so ended up chunking the json into smaller parts instead: https://github.com/Stvad/roam-notes-workflow/blob/master/.github/workflows/run_backup.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants