Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary-chart should really be sheet-def #28

Open
otfrom opened this issue Aug 11, 2022 · 0 comments
Open

summary-chart should really be sheet-def #28

otfrom opened this issue Aug 11, 2022 · 0 comments

Comments

@otfrom
Copy link
Member

otfrom commented Aug 11, 2022

https://github.com/MastodonC/witan.send.adroddiad/blob/master/src/witan/send/adroddiad/summary/report.clj#L197 doesn't really capture the domain. It should be a function for defining a sheet.

It should take:

  • map of primitives to pull from
  • selector to choose which primitives to combine
  • function to turn selected primitives into a chart
  • function to turn selected primitives into a display-table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant