Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor some of the repetitive code #10

Open
icanzilb opened this issue Sep 3, 2022 · 0 comments
Open

Refactor some of the repetitive code #10

icanzilb opened this issue Sep 3, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@icanzilb
Copy link
Collaborator

icanzilb commented Sep 3, 2022

Some of the code is a bit repetitive — some was already extracted in the "unbox" function but maybe we can do better. At the very least the logic that encodes custom types like URL needs to be in its own function in one place.
@icanzilb icanzilb added the good first issue Good for newcomers label Sep 5, 2022
@mori-ahk mori-ahk mentioned this issue Sep 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor some repetitive code
1 participant
@icanzilb