Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing or removing Blazor ViewModel RefreshAsync #1585

Closed
rockfordlhotka opened this issue Apr 24, 2020 · 2 comments · Fixed by #1587
Closed

Consider changing or removing Blazor ViewModel RefreshAsync #1585

rockfordlhotka opened this issue Apr 24, 2020 · 2 comments · Fixed by #1587
Assignees

Comments

@rockfordlhotka
Copy link
Member

As per this thread: MarimerLLC/cslaforum#938

The RefreshAsync method is very opinionated and may not offer enough value to overcome the confusion is creates.

Or perhaps it should accept an expression so the data portal can be invoked directly:

  vm.RefreshAsync(async () => await DataPortal.FetchAsync<DomainType>());
@rockfordlhotka
Copy link
Member Author

The final implementation here is to remove the old RefreshAsync method in favor of a new one that accepts a data portal or factory method:

  await vm.RefreshAsync(() => DataPortal.FetchAsync<PersonEdit>(123));

rockfordlhotka added a commit to rockfordlhotka/csla that referenced this issue Apr 27, 2020
Version 5.2.0 automation moved this from In progress to Done Apr 29, 2020
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Version 5.2.0
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant