Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend EnumConverter to use EnumMemberAttribute #417

Open
jkonecki opened this issue Feb 18, 2022 · 1 comment
Open

Extend EnumConverter to use EnumMemberAttribute #417

jkonecki opened this issue Feb 18, 2022 · 1 comment

Comments

@jkonecki
Copy link

EnumConverter is internally using Enum.Parse method that assumes that the parsed value matches the name of the enum value.

System.Runtime.Serialization has an EnumMemberAttribute (https://docs.microsoft.com/en-us/dotnet/api/system.runtime.serialization.enummemberattribute) that can be used to decorate each field and specify a different value:

public enum Position
{
    [EnumMember(Value = "Emp")]
    Employee,
    [EnumMember(Value = "Mgr")]
    Manager,
    [EnumMember(Value = "Ctr")]
    Contractor
}

This allows for easy definition of mapings between 'proper' names of enum options and the actual string values that will be serialized.

I would like to extend EnumConverter to utilize the EnumMemberAttribute during conversion.

Please let me know if you would be interested in my PR for this change.

@jonnyruffles
Copy link

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants