Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] precursor_indices definition #265

Open
jspaezp opened this issue Feb 27, 2023 · 2 comments
Open

[Question] precursor_indices definition #265

jspaezp opened this issue Feb 27, 2023 · 2 comments

Comments

@jspaezp
Copy link

jspaezp commented Feb 27, 2023

Hello!

I have been exploring the package and had a question on how the 'precursor_indices' is defined.
When I filter based on the precursor index (1 in this case), get two distinct quad isolation.

This is contrary to what I thought would be the case (I was expecting each precursor to be only one iso window), so I wanted to know whether this is an expected behavior or how the precursor index is being defined.

Is there any indexing to access unique quad isolation windows in a sequential manner?

Appreciating your help!
-Sebastian

Snippet showing how I am getting the results

# This file comes from the PRIDE repo for the alphatims paper
# curl ftp.pride.ebi.ac.uk/pride/data/archive/2022/02/PXD028735/LFQ_timsTOFPro_diaPASEF_Ecoli_01.d.zip --output ../data/ecoli_timsTOFPro_diaPASEF.d.zip
dia_data = TimsTOF("../data/LFQ_timsTOFPro_diaPASEF_Ecoli_01.d", mmap_detector_events=False)
inds = dia_data[{"precursor_indices": 1}, "raw"]
out = dia_data.convert_from_indices(inds,
        raw_indices_sorted=True,
        return_quad_mz_values=True,
        )
np.unique(out["quad_low_mz_values"], return_counts=True)
# (array([400., 800.]), array([ 20845610, 119548979]))
@sander-willems-bruker
Copy link
Collaborator

Dear @jspaezp . This is the original intended behavior (see page 18-19 of the GUI manual).
I understand that this indeed can be a confusing situation, but at the time I felt it was the best option since "precursor_indices" is first-and-foremost a DDA feature (if only by using the name "precursor") and only an afterthought for DIA. After the initial implementation two years ago, I now agree that defining DIA precursor_indices as a single "window" might make more sense than the current definition of a "window group". That said, with new acquisitions such as synchroPASEF, the "window group" definition might again become the more dominant use case. As such, I will leave it unchanged for now to ensure backwards compatibility and avoid any further confusion.

With respect to your second question on how to select unique quad isolition windows in a sequential manner, I personally tend to use quad setting directly to do this. Notice that you should be able to find all those easily by viewing the analysis.tdf with any sql browser, or by checking out the .cycle attribute of a TimsTOF object.

@jspaezp
Copy link
Author

jspaezp commented Feb 28, 2023

@sander-willems-bruker Thank you very much for the reply! that makes a lot of sense now!
I think it would be great to have some of this info in the python API documentation. I am not sure if I just missed it or it it is too small of a user-niche to invest in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants