Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin Python requirements #59

Open
ecederstrand opened this issue Dec 20, 2022 · 0 comments · May be fixed by #60
Open

Unpin Python requirements #59

ecederstrand opened this issue Dec 20, 2022 · 0 comments · May be fixed by #60

Comments

@ecederstrand
Copy link

Overview

https://github.com/MannLabs/alphamap/blob/master/requirements.txt pins a handful of Python package dependencies, e.g. numpy==1.19.2. I cannot decide from the commit history that this is due to specific requirements of alphamap.

Pinning packages makes it difficult to combine alphamap with other packages that also depend on e.g. numpy. Instead, it would be helpful to specify dependencies either open, numpy>=1.19.2, or limited to the next major version (numpy>=1.19.2,<2), assuming dependency maintainers adhere to semantic versioning and don't introduce breaking changes between major versions.

Dependencies that need more specific versions could be pinned with a commit that references the issue describing the reasoning for pinning to exact versions. Then it's easier to go back later and check if the pinning is still necessary.

ecederstrand added a commit to ecederstrand/alphamap that referenced this issue Dec 20, 2022
@ecederstrand ecederstrand linked a pull request Dec 20, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant