Add lookat-translating zoom mode for Camera3D #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3792
Adds a mode which translates lookat rather than eyeposition, avoiding the camera getting moved inside a shape. To avoid the center of rotation changing the pr adds a
static_lookat. It is used as the center of rotation and ignores translations done by zooming. The resulting behavior depends on other settings:cad = truethe cameras lookat is held on the connecting line between eyeposition and static_lookat. This should lead to different rotation speeds when zooming but nothing jarring.cad = false, zoom_shift_lookat = true(default) lookat and eyeposition get translated, leading to rotations no longer being centered at the screen center. This becomes more messy when translating the camera, as that translates static_lookat too, i.e. it keeps the pivoted rotation.zoom_target = :lookatthings should continue to work as they did beforeType of change
needs some more testing to be sure it's not breaking...
Checklist