Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file loading on Windows #15

Open
luknw opened this issue Sep 16, 2019 · 1 comment
Open

Fix file loading on Windows #15

luknw opened this issue Sep 16, 2019 · 1 comment
Labels
bug Something isn't working
Projects
Kocham Krzysia

Comments

@luknw
Copy link
Collaborator

luknw commented Sep 16, 2019 •
edited

What happens?

Currently, the state is loaded using dofile(). This is not portable and doesn't work on Windows as reported by @KMorawiecki.

How to reproduce?

The error screen pops up on starting the game on Windows.

How to fix?

All accesses to files should probably use love.filesystem.*
@luknw luknw added this to To do in Kocham Krzysia via automation Sep 16, 2019
@luknw luknw added the bug Something isn't working label Sep 16, 2019
@luknw
Copy link
Collaborator Author

luknw commented Sep 18, 2019

Right now, loading configs just uses require, so the issue is alleviated. However, when we switch to loading saves instead of static assets it will pop up again, so it's worth investing time to make things the right way using love.filesystem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Kocham Krzysia
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luknw