Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better PROXY_PROTOCOL #3221

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Better PROXY_PROTOCOL #3221

wants to merge 5 commits into from

Conversation

nextgens
Copy link
Contributor

@nextgens nextgens commented Apr 8, 2024

What type of PR?

Feature

What does this PR do?

  • Disable IMAP, POP3 and Submission by default; see https://nostarttls.secvuln.info/ on why explicit TLS is going away.
  • Change the semantic of PROXY_PROTOCOL to make it configurable per port
  • fix TLS_FLAVOR=notls not working with snappymail
  • fix TLS_PERMISSIVE
  • remove KUBERNETES_INGRESS; shouldn't be needed anymore
  • update the documentation and the reverse proxy example

Related issue(s)

Prerequisites

Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

  • In case of feature or enhancement: documentation updated accordingly
  • Unless it's docs or a minor change: add changelog entry file.

@nextgens nextgens added priority/p2 Minor bug / Could have type/feature Introduces a new feature labels Apr 8, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 8, 2024

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors-mailu bot added a commit that referenced this pull request Apr 8, 2024
@bors-mailu
Try #3221:
55bb024
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Apr 8, 2024

try

Build succeeded:

@Diman0 Diman0 added this to the 2024.x milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Diman0 Diman0 Awaiting requested review from Diman0

@ghostwheel42 ghostwheel42 Awaiting requested review from ghostwheel42

Assignees
No one assigned
Labels
priority/p2 Minor bug / Could have type/feature Introduces a new feature
Projects
None yet
Milestone
2024.x
Development

Successfully merging this pull request may close these issues.

snappymail integration broken with TLS_FLAVOR=notls in master
2 participants
@nextgens @Diman0