Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FAQ entry for deleting IPs from rate limiter #2932

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add FAQ entry for deleting IPs from rate limiter #2932

wants to merge 5 commits into from

Conversation

sholl
Copy link
Contributor

@sholl sholl commented Sep 1, 2023 •
edited by nextgens

What type of PR?

enhancement of documentation

What does this PR do?

adds an FAQ-entry how to manually delete an IP from rate limiter

Related issue(s)

Prerequisites

Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

  • In case of feature or enhancement: documentation updated accordingly
  • Unless it's docs or a minor change: add changelog entry file.

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors bot added a commit that referenced this pull request Sep 1, 2023
@bors
Try #2932:
eabb60d
@bors
Copy link
Contributor

bors bot commented Sep 1, 2023

try

Build failed:

ghostwheel42
ghostwheel42 previously approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@ghostwheel42 ghostwheel42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nextgens
Copy link
Contributor

nextgens commented Sep 2, 2023

I think we should document that tokens are exempt from rate limits... and remind people of AUTH_RATELIMIT_EXEMPTION instead.

@sholl
Copy link
Contributor Author

sholl commented Sep 2, 2023

I think we should document that tokens are exempt from rate limits... and remind people of AUTH_RATELIMIT_EXEMPTION instead.

good point, I will update this PR soon.

@sholl
Add hints for token-based auth and
1aa0f89 
AUTH_RATELIMIT_EXEMPTION
@mergify mergify bot dismissed ghostwheel42’s stale review September 2, 2023 09:16

Pull request has been modified.

@ghostwheel42 ghostwheel42 added the type/documentation Add or updates the documentation label Sep 9, 2023
ghostwheel42
ghostwheel42 previously approved these changes Sep 9, 2023
View reviewed changes
@Diman0
Copy link
Member

Diman0 commented Nov 19, 2023

bors try

bors-mailu bot added a commit that referenced this pull request Nov 19, 2023
@bors-mailu
Try #2932:
6a9ab75
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Nov 19, 2023

try

Build succeeded:

nextgens
nextgens previously requested changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@nextgens nextgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth mentioning on AUTH_RATELIMIT_USER that tokens are exempted

docs/faq.rst Outdated Show resolved Hide resolved
@sholl @nextgens
Update docs/faq.rst
c20ef32 
use @nextgens suggestion

Co-authored-by: Florent Daigniere <nextgens@users.noreply.github.com>
@mergify mergify bot dismissed stale reviews from ghostwheel42 and nextgens November 22, 2023 19:08

Pull request has been modified.

@sholl
Copy link
Contributor Author

sholl commented Nov 22, 2023

Thanks for the suggestions, I added them.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 22, 2024

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors-mailu bot added a commit that referenced this pull request Feb 22, 2024
@bors-mailu
Try #2932:
1b5d277
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Feb 22, 2024

try

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nextgens nextgens nextgens left review comments

@ghostwheel42 ghostwheel42 ghostwheel42 left review comments

Assignees
No one assigned
Labels
type/documentation Add or updates the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unblock IP from rate limiter?
4 participants
@sholl @nextgens @Diman0 @ghostwheel42