Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconPacks for Uno Platform #238

Open
byrialsen opened this issue Oct 12, 2020 · 9 comments
Open

IconPacks for Uno Platform #238

byrialsen opened this issue Oct 12, 2020 · 9 comments

Comments

@byrialsen
Copy link

[Feature request]
Could be nice to be able to use IconPacks for the Uno Platform.

@punker76
Copy link
Member

@byrialsen Sounds interesting, I'll look for this. But need some learning about Uno and how to create packages for it.

@ParthMandalia
Copy link

I am creating MahApps Icon pack browser (from the browser already available in this repo) in Uno platform. I have UWP version running. If there is support for Uno, probably this application will support all the platforms ( IOS, Android, WebAssembly, UWP
and Linux).

Design will be polished based on different form factor.
1

Thanks

@punker76
Copy link
Member

@pdm19882004 Can you point me to the repo? It would be nice to see the code. 👍

@ParthMandalia
Copy link

@pdm19882004 Can you point me to the repo? It would be nice to see the code. 👍

I am currently Uploading it and will post the repo link here.

Thanks

@ParthMandalia
Copy link

https://github.com/pdm19882004/MahAppIcons

(First commit in Github. Sorry if made any mistakes and I hope my Naming of project is not the problem like taking credit of this Project or something)

@timunie
Copy link
Contributor

timunie commented Oct 14, 2020

Hi @ParthMandalia

The idea is great and your first draft is IMO beautiful. But there is more to consider, so for now we want to stick with the current design. Nevertheless we can discuss yours when the uno support is implemented. :-)

(First commit in Github. Sorry if made any mistakes and I hope my Naming of project is not the problem like taking credit of this Project or something)

Please do us (and you) a favour: Instead of creating your own repo for it and copy / paste all the stuff there, fork this repo and create a new branch for your idea. This would make it possible to merge it if it is ready some day.

Happy coding
Tim

@ParthMandalia
Copy link

Please do us (and you) a favour: Instead of creating your own repo for it and copy / paste all the stuff there, fork this repo and create a new branch for your idea. This would make it possible to merge it if it is ready some day.

I have forked this repo and created a branch. I am not sure for the next steps. Please guide me.

@ParthMandalia
Copy link

ParthMandalia commented Oct 24, 2020

I was able to partially build Uno class library for this project. I have only used one icon pack (BoxIcon) to test the project as of now. Since there are many projects to build (15 projects {3 projects with Android, UWP, WASM, IOS, Mac each}), there is a randomly generated bug (Uno.SourceGenerationTasks.targets) in any one of the project and entire library fails to build. Should I upload the project solution here? Note: I have removed all the WPF components from the project.

@ParthMandalia
Copy link

ParthMandalia commented Jan 24, 2021

I was able to successfully compile the MahAppsIcons UNO class library locally (without github). And trying to link the project with my master branch.

I dont know what changes are required in Directory.builds.props / *.csproj files

Error Could not copy the file "\packages\mahapps.metro.iconpacks\3.0.0\lib\uap10.0.17763\MahApps.Metro.IconPacks.BoxIcons\Themes\Generic.xbf" because it was not found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants