Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused matchers #96

Open
shanethehat opened this issue Apr 6, 2015 · 0 comments
Open

Unused matchers #96

shanethehat opened this issue Apr 6, 2015 · 0 comments

Comments

@shanethehat
Copy link
Member

There are a number of matcher objects in Magespec that do not appear to be used anywhere.

The following matchers are currently defined:

  • BeInArea
  • BeOfType
  • Contain
  • DispatchEvent
  • HaveHeader
  • HaveName
  • HaveStatus
  • MatcherCollection
  • RenderLayoutHandle
  • RenderTemplate
  • RespondWith
  • Translate

Of these, only BeInArea has any contents. It appears to be trying to use an underlying Mage object to determine which site area a controller exists in. Since we do not currently support an underlying Mage object, this seems like it requires a decision on how integrated Magespec should be.

For all the empty matchers, we need to decide whether they should be implemented or not. Some of them will not be at all practical in a non-integrated tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant