Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compilation fails with RogueVector #1360

Open
jamiebullock opened this issue Jul 24, 2023 · 1 comment
Open

Windows compilation fails with RogueVector #1360

jamiebullock opened this issue Jul 24, 2023 · 1 comment

Comments

@jamiebullock
Copy link

I'm trying to compile "natively" on Windows 64-bit.

Currently using:

python waf configure --lightweight= --fft=KISS --build-static --msvc_targets="x64"

The build fails with many instances of:

c:\git\essentia\latest\src\essentia\roguevector.h(97): error C2039: '_Mylast': is not a member of 'essentia::RogueVector<T>'

Anyone know how to get around this?

@jamiebullock
Copy link
Author

OK, the reason for this is that RogueVector relies on internal implementation details of std::vector, and these have now changed in the latest Microsoft C++ Standard Library.

So rather than std::vector::_Mylast we now have (for example) std::vector::_Mypair._Myval2._Mylast where _Mypair is private.

I don't see any way around this besides rewriting RogueVector so that it no longer inherits std::vector (something that should arguably done anyway). It should use a non-owning data structure such as std::span.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant