Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When trying to hit void nade trapped players, only one of them gets damaged #1153

Open
farooqkz opened this issue May 31, 2023 · 10 comments
Open

Comments

@farooqkz
Copy link
Contributor

I am not totally sure about this, but I see the visual effect on just one of the trapped players.

@a-blob
Copy link
Contributor

a-blob commented Jun 6, 2023

Yes, I've experienced this before. Only one of them takes damage.

@LoneWolfHT
Copy link
Member

Worth double-checking that it damages everyone it traps, otherwise I think it may just be a visual bug engine-side

@farooqkz
Copy link
Contributor Author

farooqkz commented Jul 4, 2023

Worth double-checking that it damages everyone it traps, otherwise I think it may just be a visual bug engine-side

I confirm only one of the trapped players get damaged.

@LoneWolfHT
Copy link
Member

I confirm only one of the trapped players get damaged.

I was talking about checking the code, which does damage everyone it traps

@LoneWolfHT
Copy link
Member

Oh, is the name of this issue supposed to be When trying to hit players trapped by the void nade, only one of them gets damaged ?

That's expected/intended behavior if so. Try throwing a grenade instead

@LoneWolfHT
Copy link
Member

Ah, line 21 of grenades.lua prevents grenades from going through objects

@farooqkz
Copy link
Contributor Author

farooqkz commented Jul 5, 2023

Oh, is the name of this issue supposed to be When trying to hit players trapped by the void nade, only one of them gets damaged ?

That's expected/intended behavior if so. Try throwing a grenade instead

You mean it's fine that when more than one are trapped into a void nade, only one of them get damaged on hit? And you intended only the grenades damage ALL trapped players?

@LoneWolfHT
Copy link
Member

You mean it's fine that when more than one are trapped into a void nade, only one of them get damaged on hit? And you intended only the grenades damage ALL trapped players?

Yeah, items only target one person by default, and the mode is called 'Nade Fight'

@farooqkz
Copy link
Contributor Author

farooqkz commented Jul 6, 2023

Okay I will check if the grenade damage work for all trapped players or just one.

@LoneWolfHT
Copy link
Member

LoneWolfHT commented Jul 6, 2023

Okay I will check if the grenade damage work for all trapped players or just one.

I don't think it does, unless it insta-kills every player it hits. Going to push a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants