Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of Thompson MP lookup tables should reflect single or double precision build #776

Open
davegill opened this issue Jan 4, 2021 · 0 comments

Comments

@davegill
Copy link

davegill commented Jan 4, 2021

Regardless of the requested precision when building MPAS, when the build_tables executable generates data, the file names are:

MP_THOMPSON_freezeH2O_DATA.DBL
MP_THOMPSON_QIautQS_DATA.DBL
MP_THOMPSON_QRacrQG_DATA.DBL
MP_THOMPSON_QRacrQS_DATA.DBL

I was trying to figure out how to generate the single precision data. But the ".DBL" extension does not identify the precision of the look-up tables.

There is a Makefile macro, PRECISION, in the top-level Makefile.

The src/core_atmosphere/Makefile has a target, utilities, that drops into the utils directory to build the executables.

Perhaps a CPP flag could be added to the build of the build_tables executable. If PRECISION=single, then the suffix could be "SNGL" (or non-existent). If the default double precision is selected, then the suffix would still be "DBL".

Mods would be required where these files are input into MPAS:
./src/core_atmosphere/physics/physics_wrf/module_mp_thompson.F
./src/core_atmosphere/physics/mpas_atmphys_control.F

Obviously, this is not a front-burner item. If the use of CPP flags would be acceptable inside the Fortran files, I could do this. Perhaps this would be a version 8 item?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants