Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Dependency resolution issues MDAnalysis installs #4492

Open
IAlibay opened this issue Mar 5, 2024 · 4 comments · May be fixed by #4502
Open

[CI] Dependency resolution issues MDAnalysis installs #4492

IAlibay opened this issue Mar 5, 2024 · 4 comments · May be fixed by #4502

Comments

@IAlibay
Copy link
Member

IAlibay commented Mar 5, 2024

I'll update as I get more information, but here is a very quick overview of the issue:

Due to the use of non-optional mdakits as dependencies, the MDAnalysis package now technically depends on itself. This is causing issues, particularly in CI, where we are installing MDA 2.7.0 via conda-forge and then pip installing develop on top of it. Because we are building without isolation, this is causing environment clash issues.

Solution?

A quick solution here is maybe to pip install the kits with --no-deps ahead of the MDA install? It's not pretty but it could be an easy short term solution.

@hmacdope
Copy link
Member

hmacdope commented Mar 6, 2024

This is not ideal, but I can't see an obvious way around this in packaging the kits themselves.

--no-deps seems like the best option to me, the core repo then has to manually manage kit deps themselves but this is a small price to pay to avoid this circular stuff which is bad.

@IAlibay
Copy link
Member Author

IAlibay commented Mar 7, 2024

I'll say the no-deps thing is really an initial thought for now, I really need to dig into how big a problem this is. I'm a bit concerned about how it'll work out with packaging (I imagine conda-forge isn't going to be happy with the dependency cycle).

@IAlibay IAlibay linked a pull request Mar 10, 2024 that will close this issue
7 tasks
@IAlibay
Copy link
Member Author

IAlibay commented Mar 10, 2024

Looks like just letting pip resolve the missing packages during src build may solve the problem here - at least it doesn't appear to be pulling down MDAnalysis itself.

@orbeckst
Copy link
Member

That's ugly but also transitory until we have 3.0 when we remove the stubs for migrated kits.

If the --no-deps band aid works for our CI then that's fine for now, I think.

For conda-forge I am holding my breath... I assume that if we can't get away with the circular dependency then we need to make these kits optional and ask users to install them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants