Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: replace andWait(XXXXX.millis) with actual check that operation is done #1638

Open
ptitFicus opened this issue Jul 3, 2023 · 1 comment

Comments

@ptitFicus
Copy link
Member

Several tests create entities in Otoroshi and wait a given number of ms before continuing, however in some case provided duration is not enough.

Creation method could "poll" ototoshi for created entity before returning (using stuff like awaitability) to ensure that entity is correctly taken into account before continuing test.
This could avoid some randomly failing tests and even speed up execution in some cases.

@ptitFicus ptitFicus self-assigned this Jul 3, 2023
@ptitFicus
Copy link
Member Author

Otoroshi exchange protocol V2 got some example of such tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants