Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data reader fails when installing with pip #83

Open
ramon-astudillo opened this issue Feb 14, 2018 · 1 comment
Open

Data reader fails when installing with pip #83

ramon-astudillo opened this issue Feb 14, 2018 · 1 comment

Comments

@ramon-astudillo
Copy link
Member

What happens:

When installing the guide the absolute paths are different and the lxmls.readers do not find the data.

How to solve this:

Dependencies of local files inside code should be avoided. One pythonic solution would be to force the user to give the data path when instantiating the data.

Way to reproduce:

virtualenv venv
source venv/bin/activate
pip install -r requirements.txt
pip install .    # As opposed to python setup.py develop

the run the code

import lxmls.readers.sentiment_reader as srs
corpus = srs.SentimentCorpus("books")

note that python setup.py develop will work.

@ramon-astudillo
Copy link
Member Author

Thanks to @tjppires for not following the instructions 🗡

@ramon-astudillo ramon-astudillo added this to TODO in lxmls 2018 Mar 22, 2018
@ramon-astudillo ramon-astudillo added this to TODO in lxmls 2019 Mar 22, 2019
@ramon-astudillo ramon-astudillo moved this from TODO to DONE in lxmls 2018 Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
lxmls 2019
  
TODO
Development

No branches or pull requests

1 participant