Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match RNN code and pseudo-code #194

Open
ramon-astudillo opened this issue Jul 24, 2023 · 1 comment
Open

Match RNN code and pseudo-code #194

ramon-astudillo opened this issue Jul 24, 2023 · 1 comment
Assignees

Comments

@ramon-astudillo
Copy link
Member

Ensure guide and code match for the RNN exercise. Also add possible improvements for readability and easy comparison between Numpy and Pytorch versions

this affects the file from the guide

https://github.com/LxMLS/lxmls-guide/blob/master/pages/deep_learning/deep_learning_rnn.tex#L75

and could affect followinglxmls-toolkit files

labs/notebooks/non_linear_sequence_classifiers/exercise_1.ipynb
labs/notebooks/non_linear_sequence_classifiers/exercise_2.ipynb
https://github.com/LxMLS/lxmls-toolkit/blob/master/lxmls/deep_learning/numpy_models/rnn.py

and student branch versions thereof.

equivalent guide issue LxMLS/lxmls-guide#148

@goncalorafaria
Copy link
Member

So I am confused. I checked the guide and rnn code and it matches. Whats the issue? What am I miss understanding?

Best,
Gonçalo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants