Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viterbi pseudocode has incorrect output #44

Open
miguelbalmeida opened this issue Jul 24, 2014 · 0 comments
Open

Viterbi pseudocode has incorrect output #44

miguelbalmeida opened this issue Jul 24, 2014 · 0 comments

Comments

@miguelbalmeida
Copy link
Contributor

In the guide, the pseudocode outputs just the Viterbi path, i.e., the best sequence of states. In the LXMLS code, the function "run_viterbi" from file sequences/sequence_classification_decoder.py, which is called from function "viterbi_decode" in file sequences/sequence_classifier.py, is expected to return the best sequence of states and the corresponding score:

best_states, total_score = self.decoder.run_viterbi(initial_scores, transition_scores, final_scores, emission_scores)

We should add, in the guide, that the output is the best path AND the corresponding score.

@ramon-astudillo ramon-astudillo added this to To Do in lxmls2018 Apr 8, 2018
@ramon-astudillo ramon-astudillo added this to TODO in lxmls 2019 Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
lxmls 2019
  
TODO
lxmls2018
  
To Do
Development

No branches or pull requests

1 participant