Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: How to skip the "SKIP THIS IF NOT USING A JSON FILE" message when executing model from config #35

Open
1 of 5 tasks
fvisticot opened this issue Mar 12, 2024 · 1 comment

Comments

@fvisticot
Copy link

Brick

  • model
  • feature_brick
  • app_ui
  • service
  • service_package

Description

When running the cli in config mode I get a message "SKIP THIS IF NOT USING A JSON FILE" and I need to do "Enter"

Desired Solution

Have an option to not have this message and start immediatly

Alternatives Considered

A clear and concise description of any alternative solutions or features you've considered.

Additional Context

I run the mason make model from an "exec" command and I do not want to add another complexith

@LukeMoody01
Copy link
Owner

Hi @fvisticot 👋

Thanks for opening this issue! I agree with this. I think it would be a lot better to just be able to detect this and not need to prompt it.

The current reason this is needed is due to prompting for the path file when running mason make model. It would look something like this mason make model --jsonFile ./my-json.json now when doing it like this, people can tap "tab" and auto correct their path. Where if it was a prompt I do instead, we lose that ability and could lead to people not understanding why their file was missed.

Let me take a look to see what I can do.

Again, thanks for opening the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants