Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve main.py and remove hardcoded values from display.py #176

Open
LucasPilla opened this issue Dec 2, 2023 · 5 comments · May be fixed by #183
Open

Improve main.py and remove hardcoded values from display.py #176

LucasPilla opened this issue Dec 2, 2023 · 5 comments · May be fixed by #183
Assignees
@hlai1 @PedramHaeri
Labels
enhancement New feature or request good first issue Good for newcomers help-wanted

Comments

@LucasPilla
Copy link
Owner

  • Make main.py more readable by adding some comments
  • Remove hardcoded values from display.py and move all global definitions to another file (a new one or main.py)
@LucasPilla LucasPilla added enhancement New feature or request good first issue Good for newcomers help-wanted labels Dec 2, 2023
@PedramHaeri
Copy link

Hi I would like to try and fix this issue. could you please assign it to me?

@LucasPilla
Copy link
Owner Author

Sure @PedramHaeri, when you're done I can assign the other one to you if it is still free.

@hlai1 hlai1 linked a pull request Dec 8, 2023 that will close this issue
Open
@hlai1
Copy link

hlai1 commented Dec 8, 2023

Hi @LucasPilla! I know @PedramHaeri is assigned to this issue but I've just submitted a PR (#183) to solve the issues listed in this. Please take a look if you have some time!

@sebas-inf
Copy link

As the issue seems to still be open could I be assigned the issue?

@Manishmrgn
Copy link

Hi @LucasPilla I would like to contribute to this issue. Could I be assigned to this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hlai1 hlai1

@PedramHaeri PedramHaeri

Labels
enhancement New feature or request good first issue Good for newcomers help-wanted
Projects
None yet
Milestone
No milestone
5 participants
@LucasPilla @hlai1 @Manishmrgn @sebas-inf @PedramHaeri