Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC/SC2 PPT CleanUp #1977

Open
7 of 9 tasks
hjpalpha opened this issue Sep 28, 2022 · 2 comments
Open
7 of 9 tasks

SC/SC2 PPT CleanUp #1977

hjpalpha opened this issue Sep 28, 2022 · 2 comments
Assignees
@hjpalpha
Labels
c: prize_pool chore g: starcraft Starcraft

Comments

@hjpalpha
Copy link
Collaborator

hjpalpha commented Sep 28, 2022 •
edited

remove the following from sc/sc2 ppt lpdb_placement storage once the consumers have been cleaned up:

adjust the following after standardized storage for it is added and the consumers have been adjusted accordingly
@hjpalpha hjpalpha self-assigned this Sep 28, 2022
@hjpalpha hjpalpha mentioned this issue Sep 28, 2022
Merged
@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Oct 6, 2022 •
edited

modules needing changes so they store the new way:

modules needing adjusting/cleanUp/rewrite to fit new PPT storage (and be able to clean PPT from old shit):

  • possibly combine lots of sc2/bw stuff and move it to commons
  • change lots of stuff to use match2 opponents
  • note down the modules that use points or lastVs for cleanUp once that is standardized

(*) = should be merged between sc and sc2

@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Oct 10, 2022 •
edited

points:

lastVs:

conditions on player links/opponentname, i.e. underscore issue

@hjpalpha hjpalpha mentioned this issue Feb 6, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjpalpha hjpalpha

Labels
c: prize_pool chore g: starcraft Starcraft
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hjpalpha