Display filler flag for TBD Players

[mbergen]

Can the display be modified to add a filler flag on the left of the TBD? So that if half the prize pool is filled out, the stuff is still aligned. Also, it just looks better to have it even when it's all empty imo.

Originally posted by @iMarbot in #1798 (comment)

[hjpalpha]

possible solution (lines 50-52 in /components/match2/commons/player_display.lua)

if props.showFlag ~= false then
    flagNode = String.isNotEmpty(player.flag) and PlayerDisplay.Flag(player.flag) or PlayerDisplay.Flag('filler')
end

it is important that the fillerflag also has the span with the flag class so that mobile display of flags inside bracket cells (for non team opponents) is consistent

the above code snipped should take care of that

things to keep in mind:
it will increase include size slightly
it will increase runtime slightly

[mbergen]

I wouldn't say the include size would increase, it should be the same as when all players have flags entered, right?

[hjpalpha]

I wouldn't say the include size would increase, it should be the same as when all players have flags entered, right?

in the case of players without flag it will increase slightly compared to now (on some old pages that might be the difference between reaching the limit or not, hence i mentioned it)

of course if all flags are set it will not change compared to now