Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC breaks with PHP v5.5 and v5.6 #39

Open
ryanolee opened this issue Jun 9, 2020 · 0 comments
Open

BC breaks with PHP v5.5 and v5.6 #39

ryanolee opened this issue Jun 9, 2020 · 0 comments

Comments

@ryanolee
Copy link

ryanolee commented Jun 9, 2020

Issue

Changes in recent version of react renderer break backwards compatibility with PHP versions 5.x. The composer.json file references a minimum compatibility with PHP 5.5 (

"php": ">=5.5.0",
)
However there are a number of changes in the repo that do not conform to valid PHP 5 syntax. (Using features that were only added in PHP v7+)

Versions effected

  • 5.*
  • 4.*

How to recreate

Install package in any version of php5 and follow a normal use case

How we might fix it

  • Bump the minimum PHP requirement to 7 in v5
  • Remove all changes that caused BC breaks for php 5 in v4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant