Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Properties' doesn't show 'By layer' for an entity if so assigned but the end result #1759

Open
dellus opened this issue Apr 17, 2024 · 6 comments
Open

'Properties' doesn't show 'By layer' for an entity if so assigned but the end result #1759

dellus opened this issue Apr 17, 2024 · 6 comments

Comments

@dellus
Copy link

dellus commented Apr 17, 2024

Expected behavior: 'Properties' for an entity drawn with 'by layer' should show 'By layer'.

Observed behavior: 'Properties' for an entity drawn with 'by layer' shows the attributes assigned to the layer.

LibreCAD 2.2.1 alpha 412 appimage or earlier (since introduction of Layer Tree and Pen Palette).
Puppylinux Fossapup64
@sand1024
Copy link
Contributor

mmm - not sure I understand. In which place so you observe such a behavior? In properties dialog? In active pen buttons?
Please add more details.

@dongxuli-concord-design
Copy link

By layer
By block

I do remember there's something logic cleanup needed.

@sand1024
Copy link
Contributor

mmm - I think I finally got it - if properties dialog is invoked for the entity, "By layer/By Block" label is not shown anymore, only actual color name.
Yes, it seems it's my fault related to setup of properties dialogs, I'll fix it. Actually, the intent was to show not a black/white icon for the color in dialogs, but actual color (that same logic as in active pen toolbar).
Anyway, I'll correct this with separate pull request.

@dongxuli-concord-design
Copy link

We can keep the color icon and the text "by Layer" for example. Hope it works out for all languages

@sand1024
Copy link
Contributor

yep, that was exactly my original intent - yet there is a bug in implementation I didn't notice.

@dxli
Copy link
Member

dxli commented Apr 19, 2024

I disabled the PenPallet by default.

You can remove the setting, or enable it by:

[CustomToolbars]
UsePenPallet=1

@sand1024 sand1024 mentioned this issue Apr 24, 2024
Merged
sand1024 pushed a commit to sand1024/LibreCAD that referenced this issue Apr 24, 2024
fix for LibreCAD#1759
630fb74
dxli added a commit that referenced this issue Apr 28, 2024
@sand1024 @dxli
Pen toolbar - sync pen by layer action now works if PenPalette widget…
e1437db 
… is disabled (#1763)

* pen toolbar actions (pick, apply, copy pen)

* fix deprecated role for table model(BackgroundColorRole)

* buil file fix after merge

* added action for synchronization of layer's pen with active pen in pen toolbar, so now it does not rely on PenPalette widget and it works event if widget is disabled.

* added action for synchronization of layer's pen with active pen in pen toolbar, so now it does not rely on PenPalette widget and it works event if widget is disabled.

* fix for #1759

* fix for #1752 - now pen palette and layer tree widgets are resized to support small screens.

* Update lc_widgetfactory.cpp

delete commented code

* Update rs_color.h

Fix merging errors

---------

Co-authored-by: sand1024 <sand1024@gmail.com>
Co-authored-by: Dongxu Li <dongxuli2011@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dxli @sand1024 @dellus @dongxuli-concord-design