Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving enities inside block makes copy of them #1722

Open
rola22 opened this issue Jan 12, 2024 · 2 comments
Open

Moving enities inside block makes copy of them #1722

rola22 opened this issue Jan 12, 2024 · 2 comments
Labels
bug An error which causes unexpected or unintended results regression A new bug which was not present in previous version reproducible A confirmed bug with steps to reproduce

Comments

@rola22
Copy link

rola22 commented Jan 12, 2024

Hello.
I found a bug while playing with blocks.
When i want to move enity inside block it gets copied instead of moved.

Steps to reproduce:

  • create enity (for example circle, center at 0,0; radius 50) and make block of it,
  • edit recently created block, move original circle to 25,0 (delete original), save block
  • now you have block with two circles, one at 0,0 and second at 25,0

Linux Mint
LibreCAD:
Version: 2.2.1_alpha-327-g8e102459
Compiler: GNU GCC 11.4.0
Compiled on: Jan 12 2024
Qt Version: 5.15.3
Boost Version: 1.74.0
System: Linux Mint 21.1

@lordofbikes lordofbikes changed the title [Bug] Moving enities inside block makes copy of them Moving enities inside block makes copy of them Jan 12, 2024
@lordofbikes lordofbikes added bug An error which causes unexpected or unintended results reproducible A confirmed bug with steps to reproduce regression A new bug which was not present in previous version labels Jan 13, 2024
@lordofbikes
Copy link
Member

It works as expected in 2.2.0.2 release.
In latest master the problem occur.
The problem exists only in the current document window.
Saving the drawing, close and reopen it fixes the issue.

@dxli
Copy link
Member

dxli commented Jan 14, 2024

The issue is caused by pen manipulation of RS_Insert member entities, so deleted entities are drawn with the pen of normal entities.

I'm not sure whether this should be fixed at RS_EntityContainer, RS_Insert, RS_GraphicView, or RS_Painter level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error which causes unexpected or unintended results regression A new bug which was not present in previous version reproducible A confirmed bug with steps to reproduce
Projects
None yet
Development

No branches or pull requests

3 participants