Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: NodeInfo implementation doesn't meet the 2.0 specification #4702

Closed
5 tasks done
MV-GH opened this issue May 5, 2024 · 0 comments
Closed
5 tasks done

[Bug]: NodeInfo implementation doesn't meet the 2.0 specification #4702

MV-GH opened this issue May 5, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@MV-GH
Copy link
Contributor

MV-GH commented May 5, 2024

Requirements

  • Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a single bug? Do not put multiple bugs in one issue.
  • Do you agree to follow the rules in our Code of Conduct?
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

Lemmy's NodeInfo implementation doesn't meet the requirements of the NodeInfo 2.0 specification.

  • Specification doesn't allow any of the fields to be null.
  • Protocol field must contain at least one entry. (For private instances this is null)

See
http://nodeinfo.diaspora.software/docson/index.html#/ns/schema/2.0#$$expand

Steps to Reproduce

N/A

see current implementation https://github.com/LemmyNet/lemmy/blob/b152be79516adbd542d766df7b8a1928da590ced/crates/routes/src/nodeinfo.rs

Technical Details

This broke Sign in of private Lemmy instances in Jerboa see LemmyNet/jerboa#1487

Version

0.19.4

Lemmy Instance URL

No response

@MV-GH MV-GH added the bug Something isn't working label May 5, 2024
@MV-GH MV-GH changed the title [Bug]: NodeInfo implementation doesn't follow the 2.0 specification [Bug]: NodeInfo implementation doesn't meet the 2.0 specification May 5, 2024
@dessalines dessalines added this to the 0.19.4 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants