Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Signing P2SH transaction #24

Open
sigHash opened this issue Nov 9, 2018 · 3 comments
Open

Signing P2SH transaction #24

sigHash opened this issue Nov 9, 2018 · 3 comments

Comments

@sigHash
Copy link

sigHash commented Nov 9, 2018

Hi @NicolasDorier

Should I expect SignTransactionAsync to work just fine for p2sh transactions if I pass in ScripCoin in SignatureRequest?

@NicolasDorier
Copy link
Contributor

Yes. Though if it is not segwit, you need the input transaction as well.

@sigHash
Copy link
Author

sigHash commented Nov 10, 2018

Just wondering why we call it signedCoins:

public async Task<Transaction> SignTransactionAsync(KeyPath keyPath, ICoin[] signedCoins, Transaction[] parents, Transaction transaction, KeyPath changePath = null)

@NicolasDorier
Copy link
Contributor

Don't use this overload, use the one with SignatureRequest.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants