Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move v in chainID field #196

Open
pscott opened this issue Sep 22, 2021 · 0 comments
Open

Move v in chainID field #196

pscott opened this issue Sep 22, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@pscott
Copy link
Contributor

pscott commented Sep 22, 2021

Currently we have the function get_chain_id() which fetches the chainId either from v or from chainID depending on the transaction type.
Ideally we'd like to move v to chainID, set chainID.length to vLength. I don't know if they share the same endianness.

This would simplify get_chain_id(), and allow us to call get_chain_id() in the plugins (this function would need to be exported in the ethereum-plugin-sdk).

@pscott pscott added the enhancement New feature or request label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant