Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to repo #216

Open
xvxx opened this issue Dec 6, 2022 · 1 comment
Open

Add tests to repo #216

xvxx opened this issue Dec 6, 2022 · 1 comment

Comments

@xvxx
Copy link
Collaborator

xvxx commented Dec 6, 2022

There is an out-of-date test suite at: https://github.com/Lartu/ldpltest

I think it would be really nice if the tests were included and you could just run make test to see if you broke anything, without having to mess with another repo:

  • Add tests into the main repo
  • Mention them in the README
  • Mention them in the CONTRIBUTING guide
  • Require tests for all new statements and features
  • Run tests using GitHub Actions after every commit
  • Add make test or some other way to easily run the tests

I am not sure why they're not part of the repo, honestly, so I'm not really sure what case to make. Right now we are making it harder for people to contribute by requiring them to do work to get the tests going, when in many other software projects the tests are just included in the repo directly.

If they really need to be kept in a separate repo, it would be nice if they were included as a git submodule and there was an automated way to clone and test them.

@Lartu
Copy link
Owner

Lartu commented Dec 8, 2022

think it would be really nice if the tests were included and you could just run make test to see if you broke anything, without having to mess with another repo.

Ah this is wonderful! Really, I don't know why they aren't part of the repo either. They should be. I'm sure they are pretty outdated, but it would be nice to migrate them over, make sure they are up to date and add tests for every command that's lacking them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants